Add wilson with solution helper method #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciaquirke
force-pushed
the
luciaq-122-wilson-solution
branch
3 times, most recently
from
fd541c5 to
0d252fe
Compare
luciaquirke
force-pushed
the
luciaq-122-wilson-solution
branch
from
0d252fe to
7719b1c
Compare
|
Bump :) |
19 tasks
mivanit
reviewed
Apr 17, 2023
There was a problem hiding this comment.
I think it's cleaner to have a single method to take the name of a generator and a grid shape, for when we add more generation algos. I've got an implementation of this in #177
def get_maze_with_solution(gen_name: str, grid_shape: Coord) -> SolvedMaze:
maze: LatticeMaze = GENERATORS_MAP[gen_name](grid_shape)
solution: CoordArray = np.array(maze.generate_random_path())
return SolvedMaze.from_lattice_maze(lattice_maze=maze, solution=solution)do you think its a good idea to add that to this PR? either #177 or #162 contains code to run through all generators and test them, which I think is also cleaner than testing them individually.
mivanit
added
the
move-to-dataset-lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't use this method's outputs with PlotMaze which made me realise we have a bunch of similar but incompatible types that are keeping me from using the solved maze with the PlotMaze.add_true_path. I think we may need to merge CoordTup and Coord, and replace CoordArray with list(CoordTup). Or at least be consistent with how we do it. Not necessary for this PR though.